Implement `dpnp.interp()` #2417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

vlad-perevezentsev wants to merge 54 commits into master from impl_of_interp

Collaborator

vlad-perevezentsev commented Apr 11, 2025

This PR suggests adding an implementation of dpnp.interp() with sycl_kernel including support for all function arguments.

Have you provided a meaningful PR description?
Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
Have you checked performance impact of proposed changes?
Have you added documentation for your changes, if necessary?
Have you added your changes to the changelog?

vlad-perevezentsev added 17 commits

April 2, 2025 04:25


          Initial impl of dpnp.inter()

a24d367


          Second impl with dispatch_vector[only floating]

e2b20b0


          Implement interpolate_complex

f7d1da9


          Move interpolate backend to ufunc

e1b8698


          Move def interp()to dpnp_iface_mathematical


          Use dispatch vector and remove interpolate_complex_impl

7866eb8


          Add more backend checks

51b3bde


          Add support left/right args

ecfa37d


          Use get_usm_allocations in def interp

5d53f9c


          Pass idx as std::int64_t

9dbc2c5


          Add proper casting input array

1bafd7c


          Update def interp to support period args

2f43fd7


          Return fp[-1] instead of right_val for x==xp[-1]

ae65091


          Unskip cupy tests for interp

771d3eb


          Add dpnp tests for interp

5cda3d2


          Update docstrings for def interp()

a65a1dd


          Merge master into impl_of_interp

Contributor

github-actions bot commented Apr 11, 2025 •

edited

Loading

Array API standard conformance tests for dpnp=0.18.0dev2=py312he4f9c94_55 ran successfully.
Passed: 1222
Failed: 0
Skipped: 9

vlad-perevezentsev added 2 commits

April 11, 2025 08:53


          Remove lines after merging

99cc8b5


          Merge master into impl_of_interp

5ec0738

Collaborator

coveralls commented Apr 11, 2025 •

edited

Loading

coverage: 72.098% (-0.2%) from 72.271%
when pulling 4bf2b03 on impl_of_interp
into 2b30bab on master.

Contributor

github-actions bot commented Apr 11, 2025

View rendered docs @ https://intelpython.github.io/dpnp/pull/2417/index.html

vlad-perevezentsev added 4 commits

April 14, 2025 02:45


          Add type_check flag to cupy tests

1263eb5


          Merge master into impl_of_interp

7c1fdf1


          Add common_interpolate_checks with common utils

b84dd7e


          Reuse IsNan from common utils

e9e357c

antonwolfy added this to the 0.18.0 release milestone

vlad-perevezentsev added 3 commits

April 14, 2025 07:45


          Remove dublicate copy

50e4513


          Add _validate_interp_param() function

dbeb313


          Impove code coverage

dbb1b55

vlad-perevezentsev requested review from vtavana and ndgrigorian as code owners

April 15, 2025 12:36

antonwolfy reviewed

View reviewed changes

dpnp/backend/extensions/ufunc/elementwise_functions/interpolate.cpp Outdated Show resolved Hide resolved

dpnp/backend/extensions/ufunc/elementwise_functions/interpolate.cpp Outdated Show resolved Hide resolved

dpnp/backend/extensions/ufunc/elementwise_functions/interpolate.cpp Outdated Show resolved Hide resolved

dpnp/backend/kernels/elementwise_functions/interpolate.hpp Outdated Show resolved Hide resolved

dpnp/backend/extensions/ufunc/elementwise_functions/interpolate.cpp Outdated Show resolved Hide resolved

dpnp/tests/test_sycl_queue.py Outdated Show resolved Hide resolved

dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved

dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved

dpnp/dpnp_iface_mathematical.py Show resolved Hide resolved

dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved

vlad-perevezentsev added 6 commits

April 28, 2025 01:53


          Move value_type_of to ext/common.hpp

b89f41a


          Address remarks

36ee455


          Merge master into impl_of_interp

92d27d8


          Address the rest remarks

3b0eb60


          Merge master into impl_of_interp

051dc50


          helper files

70611c2

AlexanderKalistratov reviewed

View reviewed changes

dpnp/backend/extensions/common/ext/common.hpp Show resolved Hide resolved

dpnp/backend/extensions/ufunc/elementwise_functions/interpolate.cpp Outdated Show resolved Hide resolved

dpnp/backend/extensions/ufunc/elementwise_functions/interpolate.cpp Outdated Show resolved Hide resolved

dpnp/backend/extensions/ufunc/elementwise_functions/interpolate.cpp Outdated Show resolved Hide resolved

dpnp/backend/extensions/ufunc/elementwise_functions/interpolate.cpp Outdated Show resolved Hide resolved

dpnp/backend/extensions/ufunc/elementwise_functions/interpolate.cpp Outdated Show resolved Hide resolved

vlad-perevezentsev added 12 commits

April 30, 2025 04:41


          Update value_type_of to support const complex type

9e06cc3


          Add check_same_dtype() to validation_utils.hpp

ba987dd


          Add check_has_dtype() to validation_utils.hpp

cbf49d4


          Use check_num_dims for left/right

fa5d07a


          Use check_same_dtype for left/right

0a4fdff


          Add vector vesion of check_num_dims to validation_utils.hpp

f368c17


          Add check_same_size to validation_utils.hpp

a7d2f50


          Merge master into impl_of_interp

62802f8


          Remove std::remove_cv_t from value_type_of_impl

b97a92e


          Remove support for non-scalar period

0f8f453


          Delete trash files

169e002


          Merge master into impl_of_interp

8bb77fa

antonwolfy reviewed

View reviewed changes

dpnp/backend/extensions/ufunc/elementwise_functions/interpolate.cpp Outdated Show resolved Hide resolved

dpnp/backend/extensions/ufunc/elementwise_functions/interpolate.cpp Outdated Show resolved Hide resolved

dpnp/backend/kernels/elementwise_functions/interpolate.hpp Outdated Show resolved Hide resolved

dpnp/backend/kernels/elementwise_functions/interpolate.hpp Outdated Show resolved Hide resolved

dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved

dpnp/tests/test_mathematical.py Show resolved Hide resolved

dpnp/tests/test_mathematical.py Outdated Show resolved Hide resolved

dpnp/tests/test_mathematical.py Show resolved Hide resolved

dpnp/tests/test_mathematical.py Outdated Show resolved Hide resolved

dpnp/tests/test_mathematical.py Outdated Show resolved Hide resolved

vlad-perevezentsev added 6 commits

May 7, 2025 04:37


          Address remarks

dd05ffe


          Update tests for interp()

b85234f


          Add support bool fp

46ea738


          Merge master into impl_of_interp

3c08905


          Update _validate_interp_param()


          Use same_kind casting

4bf2b03

antonwolfy reviewed

View reviewed changes

dpnp/backend/extensions/ufunc/elementwise_functions/interpolate.cpp

+                  auto fn = interpolate_dispatch_vector[out_type_id];
+                  if (!fn) {
+                      throw py::type_error("Unsupported dtype");

Contributor

antonwolfy May 7, 2025

Would it make sense to add printing out_type_id in the error message?

dpnp/backend/extensions/ufunc/elementwise_functions/interpolate.cpp

+              struct InterpolateOutputType
+              {
+                  using value_type = typename std::disjunction<
+                      td_ns::TypeMapResultEntry<T, sycl::half>,

Contributor

antonwolfy May 7, 2025

Do we need to have instantiated kernel with sycl::half dtype if there is no real use case where it might be used?

dpnp/dpnp_iface_mathematical.py

		@@ -348,6 +350,41 @@ def _process_ediff1d_args(arg, arg_name, ary_dtype, ary_sycl_queue, usm_type):
		return arg, usm_type


		def _validate_interp_param(param, name, exec_q, usm_type, dtype=None):

Contributor

antonwolfy May 7, 2025

Is there any way to improve the coverage here?

dpnp/tests/test_mathematical.py

+                  @pytest.mark.parametrize(
+                      "dtype_xp", get_all_dtypes(no_complex=True, no_none=True)
+                  )
+                  @pytest.mark.parametrize("dtype_y", get_all_dtypes())

Contributor

antonwolfy May 8, 2025

Suggested change

      
                @pytest.mark.parametrize("dtype_y", get_all_dtypes())
          
                @pytest.mark.parametrize("dtype_y", get_all_dtypes(no_none=True))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AlexanderKalistratov AlexanderKalistratov left review comments

antonwolfy antonwolfy left review comments

vtavana Awaiting requested review from vtavana vtavana is a code owner

ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

At least 1 approving review is required to merge this pull request.

Labels

None yet